@sdesc (short description) submission bug fix

[Timegrinder]

This is a bit of a long one to explain a long term issue that was found.

While working on some quality of life fixes to the armorcrafting system it has come to our attention that for almost the last six (yes, six) years, the administrators reviews system for short descriptions (submitted via the @sdesc command by armorcrafters) have had an issue.

The issue is that after we would complete a review, we would receive feedback that the review had been processed when it in fact wasn't, it was being lost part way through.

As a result, players were submitting short description changes, and we were reviewing them. Then the apparel would never get its short description updated and the player would never get the system response from us to their complant mail (nor would they receive our feedback).

In this time, it may have felt like any armorcrafters short description submissions were falling on deaf ears and in some cases, we even thought some players were deliberately re-submitting short descriptions that we had been repeatedly denying and providing feedback for. This aspect is likely caused by a lack of direct communication on the topic.

Unfortunately, this went on for so long for two reasons:

1) Because we, as admin, have to have a mixture of trust and faith in many of our systems depending on what sort of admin we are. We're not all coders here and unless any particular admin is a coder that understands the game language AND takes the time to trawl through things (and manages to notice) they may not become aware. If it hadn't been for this chance review the issue would have continued (So you can thank MavorTheTurnip for their brainstorm about armorcrafting issues)

and 2) because we rely heavily on player feedback to let us know when something is up. We have a few avenues for this, usually with the bug ticketing system being preferred for record-keeping and handling on our end. But the number of players * their collective time spent means they experience a lot more of the issues the game world may have than we as admin could which is why we ask you to please assist us with these things by letting us know.

While going through our records to track down the issue, I wasn't able to find anything for the time period of players or admin reporting the issue, so I can only imagine players must have felt like they were being ignored and some possible just gave up on that aspect of armorcrafting.

At present, the issue has been resolved, and I have collected the historical approvals (and what the short descriptions should have been) and rectified the issue for any apparel that still exists, though most of it has made its way out of play (it was still fixed regardless, just may not be an 'obvious change people will see retroactively').

Crafters will not be notified retroactively of approvals / denials, I've just silently applied the approved submissions.

From now on armorcrafters should receive the usual approval/denial com mails with feedback (just like armor submissions), and apparel should actually get its short description updated if approved.

...having to deliberately misspell armour so many times in a single post is doing my head in.

[TL;DR]: Short description reviews were broken for a long time and weren't being processed due to a silent bug. We're sorry. We didn't know. The approvals have been retroactively applied and new submissions should work as intended. (Old denials have not been retroactively notified)